From 321f6aaa05ab337954e6e1932a49ebbfa2b9b4f3 Mon Sep 17 00:00:00 2001 From: Simon Kuehn Date: Mon, 18 May 2026 10:11:30 +0000 Subject: [PATCH] fix: only block vision pipeline if nothing at all was readable Previously blocked on needs_review when model name/number were empty, even if manufacturer or serial were detected. Now proceeds to specs research whenever any useful field was extracted, only blocking when the nameplate was completely unreadable. Co-Authored-By: Claude Sonnet 4.6 --- .../Messenger/Handler/PhotoUploadHandler.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Infrastructure/Messenger/Handler/PhotoUploadHandler.php b/src/Infrastructure/Messenger/Handler/PhotoUploadHandler.php index 9eaacd7..2befd52 100644 --- a/src/Infrastructure/Messenger/Handler/PhotoUploadHandler.php +++ b/src/Infrastructure/Messenger/Handler/PhotoUploadHandler.php @@ -43,8 +43,12 @@ final class PhotoUploadHandler ]); $this->jobRepository->save($job); - if ('' === $result['modelNumber'] && '' === $result['modelName']) { - $job->markNeedsReview('OllamaVisionAgent: no model detected on nameplate'); + $hasAnyInfo = '' !== $result['manufacturer'] + || '' !== $result['modelName'] + || '' !== $result['modelNumber']; + + if (!$hasAnyInfo) { + $job->markNeedsReview('OllamaVisionAgent: nothing readable on nameplate'); $this->jobRepository->save($job); return;